SOLR-9280 - make nodeName a configurable parameter in solr.xml #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Randomly setting nodeName in tests which extend from |
mnilsson23
pushed a commit
to mnilsson23/lucene-solr
that referenced
this pull request
Aug 26, 2016
kelaban
force-pushed
the
jira/master/SOLR-9280
branch
from
b1de1f9 to
b9bfb85
Compare
|
Updated so the patch now applies cleanly. I've been having trouble getting tests to pass on vanilla master branch, so I cannot tell if this is causing any to fail. I've spot checked a few tests with this patch and they worked fine |
|
Additionally work for SOLR-9281 is being done here (https://github.com/kelaban/lucene-solr/tree/jira/master/SOLR-9281) but will hold out on a PR as it relies on this branch |
markrmiller
added a commit
that referenced
this pull request
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes live nodeName configurable via solr.xml by setting
To test, I randomly set nodeName in
AbstractFullDistribZkTestBasefor complete coverage.I've gotten all tests to pass both when ALWAYS using a random nodeName and with it being set randomly. However during one particular run I got a test failure for the following:
ant test -Dtestcase=TestReqParamsAPI -Dtests.method=test -Dtests.seed=391BC4715DE8C2FE -Dtests.slow=true -Dtests.locale=pl-PL -Dtests.timezone=Asia/Chungking -Dtests.asserts=true -Dtests.file.encoding=UTF-8but am unable to reproduce the issue in eclipse and at this time am not sure if its related